fix: patch svm-rs to fix duplicate solc 0.8.31 build error #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream svm-rs-builds has a bug where solc version 0.8.31 appears twice in the solidity binaries list (once as prerelease, once as stable), causing duplicate constant definitions and build failures. This patches svm-rs and svm-rs-builds to use the fix from PR #178 which ignores prereleases in svm-builds. Related: alloy-rs/svm-rs#177
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
svm-rsandsvm-rs-buildsto use the fix from upstream PR alloy-rs/svm-rs#178 which ignores prereleases in svm-buildsSOLC_VERSION_0_8_31constant definitionsContext
Upstream
svm-rs-buildshas a bug where solc version 0.8.31 appears twice in the solidity binaries list (once as prerelease, once as stable release), causing duplicate constant definitions and E0428 compilation errors.Related: alloy-rs/svm-rs#177
Test plan
cargo clippy --all-targets --all-features -- -D warningspassescargo testpassescargo fmt --all -- --checkpassesNotes
This is a temporary fix until the upstream PR is merged and released. Once
svm-rs-builds>= 0.5.22 (or whichever version includes the fix) is released, we can remove the[patch.crates-io]section.