Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 version of uncertainty wrapper #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bwiktorowicz
Copy link

@bwiktorowicz bwiktorowicz commented May 12, 2016

Python 3 version of UncertaintyWrapper

All tests are now passing

@cedricleroy
Copy link

I would be interested in merging this. Who has the authority to do that now?

There are a couple of little things that may be improved:

  • Using from past.builtins import xrange instead of coming back to traditional range (It would avoid loosing the iteration laziness on python2.x).
  • Unused import sys in core.py
  • print statements to be removed in test_algopy.py
  • And not sure why jac_nd is not returned anymore in test_uncertainty_wrapper.py

Looks good otherwise. Just finished the Python3 compatibility for Caroursel, and it works installing this branch of UncertaintyWrapper

@mikofski
Copy link
Member

Hi @cedricleroy - awesome work! You should ask either @trevorhodges or @rickmellor to add you as the admin on the settings page. Otherwise, either @SunPowerMike , @anomam , or @BenBourne should know who owns this repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants