Skip to content

Conversation

@CodingJaw
Copy link

No description provided.

…@serialport-v12

Upgrade serialport for Node 20
…le-usernametoken-types

Handle PasswordText tokens in SoapService
…le-usernametoken-types-583b3y

Handle alternate soap header casing for auth
…le-usernametoken-types-n5dpkw

Handle UsernameToken in SOAP envelope headers
…socket-usage

Ensure WS-Discovery replies use bound socket port 3702
…tsrc-section

Add structured test source configuration options
…iguration-flow

Handle SetVideoEncoderConfiguration for test sources
@RogerHardiman
Copy link
Collaborator

this looks great and I almost missed it as the title is Node20 and had no idea there were so many other code changes in here.

@CodingJaw
Copy link
Author

CodingJaw commented Dec 26, 2025

thx still trying to figure out how to make the events work. fell free to look around. node20 branch is actually behind if i remember right i think this branch is the latest working codex/implement-onvif-digital-io-and-events

@RogerHardiman RogerHardiman changed the title Node20 Node20 - and lots of other changes Dec 26, 2025
@RogerHardiman
Copy link
Collaborator

When I get some spare time I'll start to cherry pick some of the changes into my develop2025 branch and then move them to the master branch from there.

@CodingJaw
Copy link
Author

I got a little carried away.

@RogerHardiman
Copy link
Collaborator

all changes are welcome. Out of interest, is there a particular VMS you test the changes with

@CodingJaw
Copy link
Author

I have not been using vms, I've been running locally in ubuntu or on rpi2 running kali and testing it against my annke NVR.
any suggestions welcome.

@RogerHardiman
Copy link
Collaborator

I use Milestone, ONVIF Device Manager on Windows and also use the github "agsh/onvif" NodeJS library, and ONVIER on Android (used to be called ONVIFER but they changed the name)
Plus from time to time I test with IndigoVision, Avigilon and Bosch VMS software but my licences for those expired.

@CodingJaw
Copy link
Author

thanks for the info very useful. should i switch to your develop2025 branch to code from? I think im coding from quedale's branch right now as he seemed to have fixed the node20 and implemented extra wsdl files?

@RogerHardiman
Copy link
Collaborator

I don't know who quedale is. I'lll try and find the branch

@RogerHardiman
Copy link
Collaborator

Please switch to develop2025. It has bug fixes for multiple video sources "eg Panoramic cameras" and is where I'm currently updating RPOS

@CodingJaw
Copy link
Author

CodingJaw commented Dec 29, 2025 via email

@RogerHardiman
Copy link
Collaborator

I've cherry-picked a few things (serial port and some Discovery port).
I have lots of questions on the Authentication and will leave that for the moment, and come back to it later. I've seen one other commercial VMS send WS authentication with PasswordText, which is disallowed in the ONVIF Spec, so the VMS programmers got it wrong. (they probably used some SOAP authentication library and did not use it correctly).
For some of the other changes I need to understand more what the issue was you were solving.

I'll continue on with some of the other commits soon.

Thanks for the PR
Roger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants