sp_BlitzFirst: Made the sys.dm_os_ring_buffers CPU checks respect Linux always setting system_idle to 0. #3717
+56
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng system_idle to 0. Disabled "High CPU Utilization - Not SQL" check on Linux. Closes BrentOzarULTD#3710.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3710.
Made the sys.dm_os_ring_buffers CPU checks respect Linux always setting system_idle to 0.
Disabled "High CPU Utilization - Not SQL" check on Linux.
In terms of tests, all that I've really done is re-run the Docker-using script that I posted in the issue and tricked Dbatools to install my branch's
sp_BlitzFirst. If you wait a minute before running the final line of my script, what you get is no longer obviously wrong.It would be prudent for somebody to test this on plain Windows and plain Linux. I have neither of those to hand. I also don't have any CPU pegging scripts that I'm happy to share. My most recent attempt killed tempdb so hard that it maxed out the storage on my SSD.