feat: Add itemModel support for 1.21.4+ to recipe results#194
Merged
Conversation
Thorinwasher
left a comment
Thorinwasher
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I have one question on using ; instead of / to separate quality.
Generally, for consistency, / would be prefereable to use. You could alternatively check initially if any ; character is present and separate based on that, otherwise go with /
# Conflicts: # src/main/java/com/dre/brewery/utility/MinecraftVersion.java
Thorinwasher
approved these changes
Jun 4, 2026
Thorinwasher
left a comment
Thorinwasher
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I think I forgot about this one, sorry 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for setting an itemmodel to brew results. Added in the recipes.yml config under itemModel. requires full path ex. namespace:path/to/model, up to three models per recipe delimited by ';' to match custommodeldata.