-
Notifications
You must be signed in to change notification settings - Fork 90
implement color temperature and lighting level #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QUDT used CCT based on input from a lighting expert. Note that quantitykind:DUV was also added to indicate the distance from the Planckian locus. |
|
Thanks for the input, Steve! I was curious if Color_Temperature is a valid concept or not in the lighting industry, but from your sharing, maybe not. I'll wait a bit more to learn others experiences and remove Color_Temperature if desired. Thanks! |
|
Just noticed that we already have Luminance_Command, which is functionally same as Lighting_Level_Command.
I'm happy with reusing the existing one (Luminance_Command) instead of introducing (Lighting_Level_Command), but want to hear others' opinions. Any preference? nikosandronikos |
|
Light as substance, Lighting as equipment seems correct to me. Regarding Lighting_Brightness vs Lighting_Level - I don't have a strong preference for one over the other. Luminance doesn't seem correct to me as a general light level descriptor, as it relates to measurement contexts more than command contexts. A luminance command is something I would give to a system that includes a sensor and a light, where the light output is adjusted based on the measured luminance (e.g. daylight harvesting). Or perhaps to some sort of calibrated lighting device (I haven't seen any of these) where the light level is described as something other than just a relative value of the total possible output power. It's also important to have corresponding Status points for each of the added commands, as the actual value used by the device may be different than the commanded value. E.g. I set a group to 100% brightness, but some of the devices within the group have a maximum of 80% set on the ballast - I'll want to know the actual status of each LED in addition to the commanded level. |
|
@jbkoh I would take a look at recent QUDT changes to make sure the units/quantity kinds are aligned |
|
@gtfierro what was our decision to directly use QUDT quantity kinds? Do we need to still define in our quantities or not? |
88fbb50 to
ef74b70
Compare
|
Use QUDT kinds directly wherever you can! If you need something that's not in there, let me know and we can define it in Brick |
|
...or even better, submit new quantity kinds to QUDT! |
ef74b70 to
784c6c4
Compare
This addresses #445 and #439. The following changes are made
Several things to discuss further within this PR.
@nikosandronikos @cbupp @OskarNSE please check this and let me know your thoughts!