fix a wrong hierarchy #544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sounds like a good change to me! |
Contributor
Author
|
Thanks. Btw, why does the unit test take forever? 4 hours unit testing is way too long for an individual contributor to iterate development |
Member
|
That is a great question and a discussion for another time! It essentially comes down to reasoning |
Member
|
@jbkoh is this PR ready for review?0 |
jbkoh
force-pushed
the
fix-differential-parents
branch
from
622da4a to
908fa4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot_Water_Differential_Temperature_Sensorshould not be a subclass of leaving temperature and entering temperature even if they are related with each other.