Skip to content

Conversation

@artoonie
Copy link
Collaborator

@artoonie artoonie commented Nov 18, 2024

This updates the theme a touch to add padding and colors and make it look a tiny bit more modern.

Before After
Screenshot 2024-11-18 at 12 31 34 PM Screenshot 2024-11-18 at 12 31 04 PM
Screenshot 2024-11-18 at 12 31 39 PM Screenshot 2024-11-18 at 12 31 09 PM

@artoonie artoonie marked this pull request as draft January 14, 2025 15:44
@artoonie
Copy link
Collaborator Author

artoonie commented Mar 11, 2025

I've fixed the issues shown in the screenshots above:
Screenshot 2025-03-14 at 8 57 04 AM
Screenshot 2025-03-14 at 8 56 51 AM

@artoonie artoonie marked this pull request as ready for review March 14, 2025 15:58
@artoonie artoonie changed the title idea: modernize CSS Update style to look a touch more modern Mar 14, 2025
@artoonie artoonie added the ready-for-code-review ready for a live code review label Mar 14, 2025
@yezr
Copy link
Collaborator

yezr commented Mar 18, 2025

image I like the new buttons and the rounded text boxes. Some things I noticed looking through that would be nice to address

1 - Name is cut off
2 - Light blue padding line?
3 - White padding around the grey background. Should it be all white or all grey? I'm thinking about change to the white background in each tab as well. Do we want it to be white or grey? The white seems almost like high contrast
4 - log messages extra padding

@artoonie
Copy link
Collaborator Author

Good eye! All addressed here:

image

As for (3), you mean changing the overall background color? I don't see much of a visual difference between white and the light gray we have on my screen.

@HEdingfield
Copy link
Contributor

One word of warning when making changes like this: please try to test in all 3 OSes (Windows, Linux, MacOS) before committing, as we can see UX regressions when messing with padding, fonts, etc.

Not 100% required, but definitely recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-code-review ready for a live code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants