Skip to content

Conversation

@ducdaiii
Copy link

Summary

  • Refactored .csproj structure for better maintainability
  • Updated metadata fields (Description, Authors)
  • Fixed potential configuration issues

Changes

  1. Moved target frameworks to shared property group
  2. Improved XML indentation for readability
  3. Verified compatibility with BrighterTargetFrameworks

Motivation

This improves code clarity and maintainability for future contributors.

Testing

  • Built successfully on .NET 6 and .NET 8
  • Verified no breaking changes in integration tests

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codescene-delta-analysis[bot]

This comment was marked as outdated.

@lillo42
Copy link
Contributor

lillo42 commented Aug 15, 2025

In your PR title, you are talking about the refactor, but you are trying to add pulsar, for apache pulsar we have this PR (#3682)

@lillo42 lillo42 marked this pull request as draft August 15, 2025 11:22
@iancooper
Copy link
Member

Hi @ducdaiii, could we collaborate on #3682?

@ducdaiii
Copy link
Author

Hi @ducdaiii, could we collaborate on #3682?

Hello, I am very willing to cooperate, it is an honor.

@ducdaiii ducdaiii closed this Aug 15, 2025
@ducdaiii ducdaiii reopened this Aug 15, 2025
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@iancooper
Copy link
Member

Going to close this in favor of working on #3682

@iancooper iancooper closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants