Allow whitelisting some email domains so they may send DMs #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chetanyakan
suggested changes
Jun 12, 2019
| RejectDMs bool `json:"RejectDMs"` | ||
| RejectGroupChats bool `json:"RejectGroupChats"` | ||
| RejectionMessage string `json:"RejectionMessage"` | ||
| AllowedDomains string `json:"AllowedDomains"` |
Contributor
There was a problem hiding this comment.
Maybe you could add some validations for AllowedDomains in IsValid method below.
| config.Mattermost.LogInfo("Got User: " + user.Email) | ||
| } | ||
|
|
||
| for _, domain := range strings.Split(conf.AllowedDomains, "\n") { |
Contributor
There was a problem hiding this comment.
Maybe you also want to trim spaces here.
|
|
||
| if user.Email != "" { | ||
| config.Mattermost.LogInfo("Got User: " + user.Email) | ||
| } |
Contributor
There was a problem hiding this comment.
-
Any particular reason for not adding a log if the users email is an empty string?
-
In the loop below, you have checked for email being in allowed domains even if it is an empty string. So, what would happen if the
AllowedDomainshas a blank line or is empty and the user's email is also empty?
Author
|
Hey @chetanyakan Thanks for your feedback, I'll look into it and try to address your inputs. |
|
I recommend to whitelist different art of taxometries. examples: Teams, Domains, User |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows specifying a list of email domains that are still allowed to send DMs if their email is on a specific domain.
This helped us reach some of the requirements needed in a large(ish) edu installation.
I'm opening this PR to elicit some feedback on the implementation. Would you be interested in adding such a feature to the disable-dm plugin? I'm sure the implementation needs some cleanup which I would take care of should you be interested in landing the feature.