Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched getJson to $.ajax with jsonp to avoid CORS errors #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SaFrMo
Copy link

@SaFrMo SaFrMo commented Jan 9, 2019

Thanks for this repo, it's super useful with the deprecation of the Yahoo API! I was running into CORS errors so I switched $.getJson to $.ajax with a jsonp data type as a fix - thought this might be helpful for others. Thanks again!

@bgallagh3r
Copy link

This would solve a lot of issues. +1

@morgant
Copy link

morgant commented Mar 25, 2019

@SaFrMo Does this method work with specifying the API Key directly or does one still have to use a proxy? Using your fork, my success callback is called, but passed undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants