Fixed kill command to work properly on linux and devcontainers #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small fix makes browsermcp work properly on Linux, thus enabling it to work on DevContainers.
On macOS
lsof -ti:9009
returns an empty string, soxargs
interprets that as "no arguments", so nokill
is run.On Linux, however,
lsof -ti:9009
returns no output, andxargs
still tries to runkill -9
, causing an error.I fixed it with a one-liner that works on both platforms and always exits with 0, so the
kill
success even if no processes are running.This enables browsermcp to be used on devcontainers by exposing port 9009, making it suitable to work no more dev environments.