Review Task 1 - #1
Open
fracz wants to merge 1 commit into
Open
Conversation
BrtqKr
reviewed
Mar 24, 2020
| @SuppressLint("ViewConstructor") | ||
| public class Line extends LinearLayout implements Serializable { | ||
| private static final long serialVersionUID = 3076583280108678995L; | ||
| private static final int TWO = 2; |
| // public void addVideoComment(File videoFile) throws CommentNotAddedException { | ||
| // } | ||
|
|
||
| private void addLineContent(boolean syntaxColor){ |
| import java.util.List; | ||
|
|
||
| /** | ||
| * View that represents one line of code. |
|
|
||
| /* | ||
| 2013-10-23, fracz, first implementation | ||
| 2013-10-30, fracz, added syntax highlighting |
Owner
There was a problem hiding this comment.
Historię można przejrzeć na gicie, komentarze śmiecą
| lineNumberView.setBackgroundColor(Color.parseColor("#008000")); | ||
| } | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Zakomentowany, niewykorzystany kod (pewnie niedokończony albo pozostałość z refaktoryzacji)
| Comment voiceComment = new Comment(AbstractComment.Type.VOICE, this); | ||
| voiceComment.setFile(recodedFile); | ||
| comments.add(voiceComment); | ||
| if (comments.size() > 0) { |
| private void addLineContent(boolean syntaxColor){ | ||
| if (!syntaxColor || !SyntaxHighlighter.canBeHighlighted(syntaxColor)) | ||
| lineContent.setText(Html.fromHtml(lineOfCode)); | ||
| else |
| */ | ||
| @SuppressLint("ViewConstructor") | ||
| public class Line extends LinearLayout implements Serializable { | ||
| private static final long serialVersionUID = 3076583280108678995L; |
| setOrientation(LinearLayout.HORIZONTAL); | ||
|
|
||
| lineNumberView = new TextView(getContext()); | ||
| lineNumberView.setText(String.format("%d.", lineNumber);); |
| // } | ||
|
|
||
| private void addLineContent(boolean syntaxColor){ | ||
| if (!syntaxColor || !SyntaxHighlighter.canBeHighlighted(syntaxColor)) |
Owner
There was a problem hiding this comment.
Można uprościć wyrażenie logiczne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find as many defects and problems as possible!