fix: ScrollableTextArea exit not responding to key press - #2713
Open
Yihong89 wants to merge 1 commit into
Open
Conversation
The check() function suspends the input handler task (xHandle) for ~10ms each time it is called. In ScrollableTextArea::show(), the update() function calls check() multiple times, creating brief windows where keyboard input is not being scanned. A quick tap of Enter during one of these suspension windows was silently swallowed, making the screen appear unresponsive. Fixed by: - Adding a 200ms delay before the wait loop to drain any buffered input - Adding EscPress as an alternative exit path (ESC key)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ScrollableTextArea
show()function (used by Host Info screen) could become unresponsive to the Enter key due to a race condition with the input handler.Root Cause
The
check()function suspends the input handler task (xHandle) for ~10ms each time it is called. InScrollableTextArea::show(), theupdate()function callscheck()multiple times (PrevPress, NextPress) before eachdraw(), creating brief windows where keyboard input is not being scanned. A quick tap of Enter during one of these suspension windows was silently swallowed, making the screen appear frozen.Fix
delay(200)before the wait loop to drain any buffered input after the content is displayedTesting