[BUG] Fix placeholder links and text errors across multiple pages - #11
[BUG] Fix placeholder links and text errors across multiple pages#11krtk119 wants to merge 7 commits into
Conversation
… link Removed Twitter and Email links from the footer and updated GitHub link.
Removed 'Contact' link from footer links.
Removed Privacy Policy and Terms of Service links from footer.
|
@krtk119 is attempting to deploy a commit to the RNeykova's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Fixes user-facing template placeholders and broken links identified in issue #10, improving navigation correctness and removing references to non-existent pages.
Changes:
- Fix pluralization for the “User Stories” label in the labs hierarchy UI.
- Replace the About page “View on GitHub” placeholder URL with the real repository URL.
- Clean up the global footer by removing placeholder social links and non-existent page links, and updating the GitHub destination.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| components/labs/CaseStudyHierarchy.tsx | Updates user story plural label generation to avoid “User Storys”. |
| components/Footer.tsx | Removes placeholder/invalid footer links and updates GitHub social link to the correct org. |
| app/about/page.tsx | Fixes “View on GitHub” button to link to the correct repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const userStoryLabel = hierarchy.labels.userStory ?? "User Story"; | ||
| const userStoriesLabel = `${userStoryLabel}s`; | ||
| const userStoriesLabel = userStoryLabel === "User Story" ? "User Stories" : `${userStoryLabel}s`; | ||
| const acLabel = hierarchy.labels.acceptanceCriteria ?? "Acceptance Criteria"; |
There was a problem hiding this comment.
Fixed - updated the pluralisation logic to use regex replace (userStoryLabel.replace(/y$/i, 'ies')) instead of a hard-coded equality check. This now correctly handles any label ending in "y", not just the default "User Story".
| const footerLinks = [ | ||
| { name: "Home", href: "/" }, | ||
| { name: "About", href: "/about" }, | ||
| { name: "Labs", href: "/labs" }, | ||
| { name: "Contact", href: "/contact" }, | ||
| ]; |
There was a problem hiding this comment.
Fixed - removed the Contact link from the Talks page footer as well (app/talks/page.tsx). Both footers are now consistent and no dead links remain.
Linked Issue
Related to #10
What Changed and Why
Several placeholder values from the project template were never updated before deployment, resulting in broken links, a spelling error, and references to non-existent pages. This PR fixes all instances identified in issue #10.
How to Test
/labs, select Requirements Engineering → User Stories and Acceptance Criteria, expand any problem — confirm label now reads "User Stories" not "User Storys"/about, scroll to bottom, click "View on GitHub" — confirm it now links to the correct repositoryType of Change
Checklist
mainon the teaching repo)Notes for Reviewer
Each fix has been committed separately for clarity. Twitter and Email social links have been removed as advised in the issue comments.