Skip to content

Automation Looping v2 #17055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Automation Looping v2 #17055

wants to merge 51 commits into from
+2,547 −806

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Sep 30, 2025 •
edited by budibase-devops-bot
Loading

Description

Implements the frontend for Automation Looping v2:

  • Adds the ability to now loop over multiple steps
  • You can either add the loop step from the step side panel, and then you can add as many steps inside if you want, or you can add an existing step and it will be pulled into a new loop block
  • Massively refactored types and other parts of the codebase including improvements to the Svelte Flow layouting algorithm

Screenshots

image

Launchcontrol

  • Adds functionality to allow the looping over multiple automation steps.

Feature branch env

Feature Branch Link

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Sep 30, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added size/xl firestorm Data/Infra/Revenue Team labels Sep 30, 2025
@PClmnt
Copy link
Collaborator Author

PClmnt commented Oct 1, 2025

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Oct 1, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@PClmnt PClmnt marked this pull request as ready for review October 2, 2025 10:35
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Oct 2, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@PClmnt PClmnt requested a review from a team as a code owner October 2, 2025 21:11
melohagan
melohagan requested changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@melohagan melohagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest this is beyond my attention span to review! With that said there is nothing in particular I could see wrong with the code.

I'll pull the branch down locally and give it a test and then come back and approve.

packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowCanvas/FlowLayout.ts
? { x: node.position.x, y: node.position.y + delta }
: { x: node.position.x + delta, y: node.position.y }
const nexts = outgoing[id] || []
for (const nId of nexts) stack.push(nId)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: I wonder if you can just do a map instead on nexts ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I think this is pretty clean

Copy link
Collaborator

@melohagan melohagan Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's fine, but could be a one liner instead of a collapsed two liner:

stack.push(...nexts)

@PClmnt PClmnt added the feature-branch Release this PR code into a feature branch label Oct 6, 2025
@joebudi
Copy link
Member

joebudi commented Oct 10, 2025

Hey. This feels more professional. I initially switched to horizontal mode - i like it better. I ran into a few UI quirks:

Drag and dropping destination highlights feel out of place
CleanShot 2025-10-10 at 10 21 21

Lines are not aligned
CleanShot 2025-10-10 at 10 17 16@2x

This is confusing. IMO the buttons should live before the divergence.
CleanShot 2025-10-10 at 10 17 22@2x

melohagan and others added 13 commits October 10, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melohagan melohagan melohagan requested changes

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@adrinr adrinr Awaiting requested review from adrinr adrinr is a code owner automatically assigned from Budibase/backend

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PClmnt @joebudi @melohagan @deanhannigan