Delete attachments on dev rows #17074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
This reverts commit 5f05303.
…nal-table-deleted-rows
melohagan
commented
Oct 3, 2025
| } | ||
|
|
||
| const prodDb = dbCore.getDB(prodAppId) | ||
| const response = await prodDb.allDocs( |
There was a problem hiding this comment.
The performance here could be an issue.
As the main problem lies with the app exports and unwanted lingering attachment files, it may be better to do a cleanup on export?
…nal-table-deleted-rows
…nal-table-deleted-rows
…nal-table-deleted-rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue when deleting dev rows that had attachments, the files were not being deleted which was leading to unwanted large app exports.
Addresses
Screenshots
delete.attachments.mov
Launchcontrol
Make sure attachments are deleted when dev rows are deleted.