Adding automation connectors & Automation toolbar UX improvements #18948
Closed
melohagan wants to merge 23 commits into
Closed
Adding automation connectors & Automation toolbar UX improvements #18948melohagan wants to merge 23 commits into
melohagan wants to merge 23 commits into
Conversation
- Rotate '+' icon when add step panel is open (matches app screen pattern) - Toggle add step panel on repeated button clicks - Close add step panel with Escape key - Fix toolbar shifting when step settings panel opens by making side panels overlay absolutely instead of participating in grid layout
Contributor
There was a problem hiding this comment.
2 issues found
Confidence score: 3/5
- There is some regression risk because both reported issues are medium severity (6/10) with fairly high confidence, and each can affect user-facing workflow behavior.
- In
packages/builder/src/components/automation/SetupPanel/layouts/APIRequest.svelte, the template auto-open behavior is not reactive toblockchanges, so connector template consumption may be skipped when moving between panel steps. - In
packages/builder/src/components/integration/APIEndpointViewer.svelte, prioritizing draft datasource while editing an existing query can desynchronizestoreQueryanddatasource, potentially applying the wrong connection context. - Pay close attention to
packages/builder/src/components/automation/SetupPanel/layouts/APIRequest.svelteandpackages/builder/src/components/integration/APIEndpointViewer.svelte- reactivity and datasource-selection logic may cause incorrect state/context during editing flows.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
📚 No documentation changes were needed for this PR (Job ID: |
Contributor
There was a problem hiding this comment.
2 issues found across 22 files
Confidence score: 4/5
- This PR looks safe to merge with minimal risk: both reported issues are low severity (4/10) and do not suggest broad breakage.
- The most user-facing concern is in
packages/builder/src/components/integration/rest/ConnectionSelect.svelte, where restricted-mode featured-section gating can hide the empty state and result in a blank menu. - In
packages/builder/src/stores/builder/automations.ts, a newly added store action is currently unused, so the pending template flow remains inactive and introduces dead code rather than an immediate regression. - Pay close attention to
packages/builder/src/components/integration/rest/ConnectionSelect.svelteandpackages/builder/src/stores/builder/automations.ts- blank-state visibility in restricted mode and inactive pending-template action behavior.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
📚 Analyzing PR for documentation updates in https://budibase-ai.readme.io/ |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds connector steps to automations, combining existing REST Templates with the API Request step.
Addresses
Screenshots
Launchcontrol
Adds connectors to automations.
Improved automation toolbar UX with icon rotation, toggle behavior, Escape key support, and fixed panel positioning. Connector steps now open the side panel directly instead of a modal.