Skip to content

fix: consistent delivery of teams source urls - #19769

Merged
Dakuan merged 1 commit into
masterfrom
fix/teams-source-delivery
Oct 1, 2026
Merged

Dakuan merged 1 commit into
masterfrom
fix/teams-source-delivery

Conversation

@Dakuan

@Dakuan Dakuan commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes Teams delivery so message replies use the incoming activity's service URL instead of the adapter default, keeping delivery consistent between card posts and DM streams.

Launchcontrol

  • fixes delivery of source urls on microsoft teams

Summary by cubic

Fixes Teams delivery so message replies use the incoming activity's service URL instead of the adapter default, keeping delivery consistent between card posts and DM streams.

  • Moves validateBody before createWebhookHandler so invalid requests fail before any adapter is built.
  • Passes the validated serviceUrl into the Teams adapter for personal replies.
  • Updates tests to cover both streaming and non-streaming responses with the custom service URL.

Written for commit 313c1fc. Summary will update on new commits.

Review in cubic

@Dakuan

Dakuan commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai

@Dakuan I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Dakuan Dakuan changed the title fix: consistent delivery fix: consistent delivery of teams source urls Oct 1, 2026
@Dakuan
Dakuan marked this pull request as ready for review October 1, 2026 08:29
@Dakuan
Dakuan force-pushed the fix/teams-source-delivery branch from b85f6f9 to 313c1fc Compare October 1, 2026 08:30

@Tobertet Tobertet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dakuan
Dakuan merged commit 0f267b0 into master Oct 1, 2026
38 checks passed
@Dakuan
Dakuan deleted the fix/teams-source-delivery branch October 1, 2026 11:26
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants