Merged
Conversation
|
@Rampop01 is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
melanke
requested changes
May 9, 2025
Collaborator
melanke
left a comment
There was a problem hiding this comment.
Thanks for your personal page!
I'd like to ask you to improve your PR's description:
- The italic texts in the template are hints for things you should follow when submitting your PR, so please follow the hints and remove them.
- Please link the issue in the PR description. You can do this using
#followed by the issue number. - Add your Ethereum address.
- Checkboxes should have an
xin the middle as part of Markdown formatting.
And here comes my review. Things I think you should improve in your code:
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
melanke
requested changes
May 13, 2025
Collaborator
melanke
left a comment
There was a problem hiding this comment.
I love how the colors of your photo matches the colors of the page, well done!
Just a few more points:
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xb216270aFB9DfcD611AFAf785cEB38250863F2C9/page.tsx
Outdated
Show resolved
Hide resolved
melanke
approved these changes
May 14, 2025
Contributor
|
Nice page, let's merge! @melanke thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds my builder profile page to the batch site.
Additional Information
Added NextPage type to the profile component for better type safety
Renamed page component to RampopProfilePage for better clarity and uniqueness
Used the existing address component to display my address
Replaced the initial SVG with my image stored in Cloudinary
The button colours are now contrasting well when dark mode is activated
Fixes the error in the browser log
Supports both light and dark mode
I have read the contributing docs (if this is your first contribution)
This is not a duplicate of any existing pull request
Related Issues
This PR addresses issue #8
Your ENS/address:
0xb216270aFB9DfcD611AFAf785cEB38250863F2C9