Skip to content

Rampop#18

Merged
phipsae merged 7 commits intoBuidlGuidl:mainfrom
Rampop01:rampop
May 14, 2025
Merged

Rampop#18
phipsae merged 7 commits intoBuidlGuidl:mainfrom
Rampop01:rampop

Conversation

@Rampop01
Copy link
Contributor

@Rampop01 Rampop01 commented May 9, 2025

Description

This PR adds my builder profile page to the batch site.

image

image

Additional Information

  • Added NextPage type to the profile component for better type safety

  • Renamed page component to RampopProfilePage for better clarity and uniqueness

  • Used the existing address component to display my address

  • Replaced the initial SVG with my image stored in Cloudinary

  • The button colours are now contrasting well when dark mode is activated

  • Fixes the error in the browser log

  • Supports both light and dark mode

  • I have read the contributing docs (if this is your first contribution)

  • This is not a duplicate of any existing pull request

Related Issues

This PR addresses issue #8

Your ENS/address:
0xb216270aFB9DfcD611AFAf785cEB38250863F2C9

@vercel
Copy link

vercel bot commented May 9, 2025

@Rampop01 is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your personal page!

I'd like to ask you to improve your PR's description:

  • The italic texts in the template are hints for things you should follow when submitting your PR, so please follow the hints and remove them.
  • Please link the issue in the PR description. You can do this using # followed by the issue number.
  • Add your Ethereum address.
  • Checkboxes should have an x in the middle as part of Markdown formatting.

And here comes my review. Things I think you should improve in your code:

@vercel
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch16.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 7:53pm

Copy link
Collaborator

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how the colors of your photo matches the colors of the page, well done!

Just a few more points:

@melanke melanke requested a review from phipsae May 14, 2025 13:10
@phipsae
Copy link
Contributor

phipsae commented May 14, 2025

Nice page, let's merge!

@melanke thanks for reviewing!

@phipsae phipsae merged commit 238f138 into BuidlGuidl:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants