Implemented my builder's profile#21
Conversation
|
@Lynndabel is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
phipsae
left a comment
There was a problem hiding this comment.
@Lynndabe,l thanks a lot for your great-looking personal page!
Just a note regarding your PR description, please make sure to fill it out instead of leaving the default template. Go ahead and update it please.
You'll find a few comments below.
If you have any questions at all, feel free to reach out!
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
|
@phipsae, I have implemented all the changes. Kindly review. Thank you. |
phipsae
left a comment
There was a problem hiding this comment.
Almost here :)
Left some comments.
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x3BFbE4E3dCC472E9B1bdFC0c177dE3459Cf769bf/page.tsx
Outdated
Show resolved
Hide resolved
|
@phipsae Please review my latest change. Thank you. |
|
Great, thanks! Let's merge. Just an advice: always check for lint errors, I was fixing them this time. |
Description
Add personal builder profile page that implements dark/light mode support, proper TypeScript typing, and follows Next.js best practices.
Additional Information
Related Issues
Closes #8