Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
phipsae
left a comment
phipsae
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR!
Please make sure to properly fill out your PR description and clearly explain what your contribution does. Simply writing "Using Tailwind CSS and TypeScript" isn't helpful, as the entire app already uses those. Also, if there are checkboxes in the template, please tick the relevant ones. (Sorry for being nitpicking here, but thats why you are here)
See below some comments.
If there are any question pls let me know.
| <div className="w-24 h-24 rounded-full bg-cover bg-center bg-no-repeat border-2 border-[#6EF4E6] text-[20px] font-bold text-white flex items-center justify-center"> | ||
| MTH | ||
| </div> | ||
| <p className="text-[24px] font-normal">Methely Armstrong</p> |
There was a problem hiding this comment.
Your name is in dark mode hardly readable. Pls change it.
| {[ | ||
| { | ||
| icon: "link", | ||
| text: "www.github.com/MethelyDev", | ||
| href: "https://www.github.com/MethelyDev", | ||
| }, | ||
| ].map(({ text, href }) => ( | ||
| <div key={text} className="flex items-center justify-start gap-4 mb-4"> | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| fill="none" | ||
| viewBox="0 0 24 24" | ||
| strokeWidth="1.5" | ||
| stroke="#6AECD9" | ||
| className="size-6" | ||
| > | ||
| <path | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| d="M13.19 8.688a4.5 4.5 0 0 1 1.242 7.244l-4.5 4.5a4.5 4.5 0 0 1-6.364-6.364l1.757-1.757m13.35-.622 1.757-1.757a4.5 4.5 0 0 0-6.364-6.364l-4.5 4.5a4.5 4.5 0 0 0 1.242 7.244" | ||
| /> | ||
| </svg> | ||
| {href ? <Link href={href}>{text}</Link> : <span>{text}</span>} | ||
| </div> | ||
| ))} |
There was a problem hiding this comment.
Is the mapping here really necessary?
There was a problem hiding this comment.
To enhance your profile a bit more, it would be nice if you could add a picture, as well as, use the SE2 component
.2 participants
Description
Created my personal builders page, added images and applied changes from reviews
Additional Information
Related Issues
_Closes #16
Your ENS/address: 0xe98540d28F45830E01D237251Bfc4777E69c9A46