Skip to content

Add Ogaga's Builder Profile with Review Fixes#32

Merged
phipsae merged 4 commits intoBuidlGuidl:mainfrom
ogazboiz:my-builder-page
May 14, 2025
Merged

Add Ogaga's Builder Profile with Review Fixes#32
phipsae merged 4 commits intoBuidlGuidl:mainfrom
ogazboiz:my-builder-page

Conversation

@ogazboiz
Copy link
Contributor

@ogazboiz ogazboiz commented May 13, 2025

Overview

This PR adds my builder profile page to the Batch 16 directory at /builders/0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5, addressing review feedback from #27. The page includes:

  • A responsive profile with bio, contact info, and social links (Twitter, GitHub, Telegram)
  • ETH address formatted using Scaffold-ETH’s Address component
  • Fixes for reviewer comments to align with project standards

Changes Addressing Review Feedback

  • New Branch: Created ogaga-profile-fixes for this PR, per review request.
  • package-lock.json: Removed, as the project doesn’t use npm lock files.
  • Image Optimization: Replaced <img> with next/image to fix ESLint warning (@next/next/no-img-element) and optimize LCP.
  • SocialLinks: Renamed to ProfileSocialLinks and moved to packages/nextjs/app/builders/0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5/_components/ for page-specific context.
  • Page Typing/Naming: Typed as NextPage and renamed to OgagaProfile for TypeScript clarity.

Technical Details

  • Route: packages/nextjs/app/builders/0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5/page.tsx
  • Component: ProfileSocialLinks in page-specific _components folder
  • Standards: Adheres to ESLint, Prettier, and TypeScript conventions
  • Dependencies: No heavy assets or large dependencies added

Preview

Preview the updated profile at:

Verification

  • ✅ Renders correctly at all breakpoints (mobile, tablet, desktop)
  • ✅ Links (Twitter, GitHub, Telegram, email) function properly
  • ✅ Follows project conventions (linting, TypeScript, Scaffold-ETH)
  • ✅ No package-lock.json included
  • ✅ ESLint <img> warning resolved with next/image

Notes

Please review and approve. 🚀

@vercel
Copy link

vercel bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch16.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 8:19pm

Copy link
Contributor

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for new PR!
Was there a specific reason to create a new PR?
I closed the other one.

Left you comments below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This denpendency doesn't belong here, since its for nextjs. Pls install it in the nextjs folder.

// Ethereum address
const myAddress = "0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5";

export default function BuilderPage() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page.

Since there are more builder profiles, it might make sense to give your component a more specific name (e.g. "YourNameProfile")

@ogazboiz
Copy link
Contributor Author

You said I should create a branch that is why

@phipsae
Copy link
Contributor

phipsae commented May 14, 2025

You said I should create a branch that is why

True, thanks :)

@ogazboiz
Copy link
Contributor Author

Hi @phipsae ,

Thanks for the feedback! 🙌 I’ve updated the component to use NextPage for better TypeScript integration and renamed it to AkpoloOgagaProfile for clarity.

Here’s a preview of the UI for this profile page:

UI Screenshot

dark mode ui

Scaffold-ETH 2 App

lightmode ui

screenshot

  • Clean, responsive layout with sections for About Me, Projects, Skills, and Contact
  • Dynamic social links with custom icons
  • ETH address display using Scaffold-ETH’s <Address> component
  • Themed styling using CSS variables (e.g., --color-primary, --color-base-100)

Changes Made:

  1. Typed the page as NextPage.
  2. renamed to AkpoloOgagaProfile

Let me know if you'd like any further adjustments!

@phipsae
Copy link
Contributor

phipsae commented May 14, 2025

Fixed an error in next.config.js to happend when you pulled in the lasted changes from main. But no worries :)

Lets merge

@phipsae phipsae merged commit a078e8e into BuidlGuidl:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants