Add Ogaga's Builder Profile with Review Fixes#32
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
phipsae
left a comment
There was a problem hiding this comment.
Thanks for new PR!
Was there a specific reason to create a new PR?
I closed the other one.
Left you comments below.
There was a problem hiding this comment.
This denpendency doesn't belong here, since its for nextjs. Pls install it in the nextjs folder.
| // Ethereum address | ||
| const myAddress = "0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5"; | ||
|
|
||
| export default function BuilderPage() { |
There was a problem hiding this comment.
You might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page.
Since there are more builder profiles, it might make sense to give your component a more specific name (e.g. "YourNameProfile")
|
You said I should create a branch that is why |
True, thanks :) |
|
Hi @phipsae , Thanks for the feedback! 🙌 I’ve updated the component to use Here’s a preview of the UI for this profile page: UI Screenshotdark mode uilightmode ui
Changes Made:
Let me know if you'd like any further adjustments! |
|
Fixed an error in next.config.js to happend when you pulled in the lasted changes from main. But no worries :) Lets merge |


Overview
This PR adds my builder profile page to the Batch 16 directory at
/builders/0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5, addressing review feedback from #27. The page includes:AddresscomponentChanges Addressing Review Feedback
ogaga-profile-fixesfor this PR, per review request.<img>withnext/imageto fix ESLint warning (@next/next/no-img-element) and optimize LCP.ProfileSocialLinksand moved topackages/nextjs/app/builders/0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5/_components/for page-specific context.NextPageand renamed toOgagaProfilefor TypeScript clarity.Technical Details
packages/nextjs/app/builders/0x2E15bB8aDF3438F66A6F786679B0bBBBF02A75d5/page.tsxProfileSocialLinksin page-specific_componentsfolderPreview
Preview the updated profile at:
Verification
package-lock.jsonincluded<img>warning resolved withnext/imageNotes
Please review and approve. 🚀