Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
melanke
requested changes
May 15, 2025
packages/nextjs/app/builders/0xB24023434c3670E100068C925A87fE8F500d909a/page.tsx
Show resolved
Hide resolved
melanke
requested changes
May 16, 2025
melanke
requested changes
May 19, 2025
Contributor
|
@Mrwicks00 just a quick reminder that we wait for your changes |
phipsae
requested changes
May 24, 2025
Contributor
phipsae
left a comment
There was a problem hiding this comment.
Thx! Just a tiny little change and then we merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR implements the Batch 16 main page updates by adding a new logo, replacing the favicon, setting the page title, and adding a subtitle, as per the task requirements (issue #7 ). The changes enhance the batch page's branding and ensure visual consistency.
Key Changes:
batch-logo.png) to the main content area of the Batch 16 page atpackages/nextjs/app/page.tsx, designed from the DALL-E logo featuring a stylized Ethereum diamond symbol with the number '16' in a blue-to-purple gradient, placed inpublic/batch-logo.png.favicon.ico(matching the batch logo), placed inpublic/favicon.ico, and removed the oldfavicon.png.getMetadatafunction inutils/scaffold-eth/getMetadata.tsto seticons.iconto/favicon.ico, resolving browser requests for the oldfavicon.png(404 errors).batch-logo.png(1.5 MB) tobatch-logo.webp, reducing the size to ~115 KB.app/batch-16/page.tsxto usebatch-logo.webp.<Image>console error by removingfilland addingwidth={288}andheight={288}.favicon.icotofavicon-v2.icoto bypass browser caching.page.tsxand596.avif) from the PR.package.jsonin this branch—it might have been a misunderstanding. I also reverted the favicon renaming fromfavicon-v2.icoback tofavicon.icoas part of cleaning up.Screenshots:
![Batch 16 Page ]
Additional Information
Your ENS/address:
0xB24023434c3670E100068C925A87fE8F500d909a