Skip to content

create-personal-page#36

Merged
phipsae merged 3 commits intoBuidlGuidl:mainfrom
nnennaokoye:feat/create-personal-page
May 16, 2025
Merged

create-personal-page#36
phipsae merged 3 commits intoBuidlGuidl:mainfrom
nnennaokoye:feat/create-personal-page

Conversation

@nnennaokoye
Copy link
Contributor

@nnennaokoye nnennaokoye commented May 16, 2025

Description

Added a new personal page to the builders directory showcasing my profile and social connections using Scaffold-ETH 2 components and modern web development practices.

image

Additional Information

Related Issues

_Closes #8

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address: 0x167142915AD0fAADD84d9741eC253B82aB8625cd

@vercel
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch16.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 9:06pm

@melanke
Copy link
Collaborator

melanke commented May 16, 2025

Hey @nnennaokoye, you might have your reasons for switching branches, but just to let you know — it's expected to continue the review process using the same PR. You could have simply updated the create-your-personal-page branch and we would’ve continued from where we stopped. But that’s fine, let’s continue from here. So please, I’ll ask you to close the other PR so we have only one for this purpose.

Now, for my feedback:
I saw in the screenshot you attached that the image is stretched. It’d be better to fix that, right?

@melanke melanke self-requested a review May 16, 2025 13:43
@melanke melanke requested a review from phipsae May 16, 2025 14:33
@phipsae phipsae merged commit d689516 into BuidlGuidl:main May 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants