Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
melanke
requested changes
May 21, 2025
Collaborator
melanke
left a comment
melanke
left a comment
There was a problem hiding this comment.
Thanks for your page!
I'd like to ask you to improve your PR's description:
- The italic texts in the template are hints for things you should follow when submitting your PR, so please follow the hints and remove them.
- Please link the issue in the PR description. You can do this using
#followed by the issue number. - Add your Ethereum address.
- Checkboxes should have an
xin the middle as part of Markdown formatting.
And here comes my review. Things I think you should improve in your code:
packages/nextjs/app/builders/0x391b638EB7d21B122Be2Ed69eb81DA7E0F168177/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x391b638EB7d21B122Be2Ed69eb81DA7E0F168177/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x391b638EB7d21B122Be2Ed69eb81DA7E0F168177/page.tsx
Show resolved
Hide resolved
packages/nextjs/app/builders/0x391b638EB7d21B122Be2Ed69eb81DA7E0F168177/page.tsx
Show resolved
Hide resolved
Ebuka Moses Profile
Ebuka Moses Profile
phipsae
requested changes
May 25, 2025
Contributor
phipsae
left a comment
phipsae
left a comment
There was a problem hiding this comment.
Almost done, there is only this little warning, that needs be fixed.
And then we merge :)
packages/nextjs/app/builders/0x391b638EB7d21B122Be2Ed69eb81DA7E0F168177/page.tsx
Show resolved
Hide resolved
Ebuka Moses Profile
Contributor
|
Let's merge! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Concise description of proposed changes, We recommend using screenshots and videos for better description
Additional Information
Related Issues
Closes #8
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: 0x391b638EB7d21B122Be2Ed69eb81DA7E0F168177