-
Notifications
You must be signed in to change notification settings - Fork 16
Add Bob builder page #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
melanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your page, here's my review:
| </div> | ||
|
|
||
| {/* About Me Card */} | ||
| <div className="card bg-base-100 shadow-xl border-2 border-accent/20 hover:border-accent/40 transition-all"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should only have hover effects for interactive elements. This hover effect misleads the user into thinking they can click it to navigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should only have hover effects for interactive elements. This hover effect misleads the user into thinking they can click it to navigate.
Done, thank you
|
Done, thank you for your review |
| {/* Address Section */} | ||
| <div className="flex justify-center"> | ||
| <div className="bg-base-100 rounded-xl px-6 py-3 border-2 border-secondary/30 shadow-lg"> | ||
| <Address address="0x4667d9b7c789c231988ec631b22c5492ce60b3e9" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry missed it, fixed
|
@bobtajson there's still formatting issues on your code. |
For me |
Description
Add personal page with skills and link to my github
Additional Information
Related Issues
Closes #10
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:
0x4667d9b7c789c231988ec631b22c5492ce60b3e9
Screenshots:

