Add my personal page #40
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| alt="ksenchi-avatar" | ||
| width={96} | ||
| height={96} | ||
| className="w-full h-full object-cover rounded-full" |
There was a problem hiding this comment.
small thought: the avatar could use priority since it’s the one of the first images on the page — not important here, just sharing in case it’s useful later :))
melanke
left a comment
melanke
left a comment
There was a problem hiding this comment.
Thanks for your page, here's my feedback:
| </h1> | ||
| <p className="text-base-content/60 text-sm md:text-base mb-3">Web3 Developer • Blockchain Enthusiast</p> | ||
| <div className="inline-block"> | ||
| <Address address="0x30172ff3ec7db91e59a84c8c5e9976b3a0a60557" /> |
There was a problem hiding this comment.
Could you update this address to the checksummed version? Using EIP-55 casing is the standard and makes it easier to spot typos, which helps avoid mistakes when someone copies or validates the address. Thanks!
Here's the correct version: 0x30172Ff3EC7Db91E59A84c8c5E9976b3A0A60557
| </div> | ||
|
|
||
| {/* GitHub Box - Middle Right */} | ||
| <div className="md:col-span-1 bg-gradient-to-br from-primary to-secondary rounded-3xl p-6 flex items-center justify-center shadow-xl hover:shadow-2xl transition-shadow"> |
There was a problem hiding this comment.
You should only have hover effects for interactive elements. This hover effect misleads the user into thinking they can click it to navigate.
|
@kseniaeremekno there are some warnings about formatting showing up when you run |
3 participants
Description
Hello sir, i'm really sorry i was too busy this time. This is my personal page with my skills and link to my github
Additional Information
Related Issues
Closes #10
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: 0x30172Ff3EC7Db91E59A84c8c5E9976b3A0A60557
Screenshots:
