Closed
Conversation
|
@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pabl0cks
reviewed
Aug 25, 2025
| <td className="py-3 px-2 xs:px-4">{batch.name}</td> | ||
| <td className="py-3 px-2 xs:px-4 hidden lg:table-cell">{formatDate(batch.startDate)}</td> | ||
| <td className="py-3 px-2 xs:px-4 hidden sm:table-cell">{batch.totalParticipants || "-"}</td> | ||
| <td className="py-3 px-2 xs:px-4 hidden sm:table-cell">{batch.totalParticipants}</td> |
Member
There was a problem hiding this comment.
Should we keep the old fallback || "-" ?
Pabl0cks
reviewed
Aug 25, 2025
| Website | ||
| </TrackedLink> | ||
| <div className="flex items-center gap-1"> | ||
| {batch.nftContractAddress && batch.graduates && batch.graduates > 0 ? ( |
Member
There was a problem hiding this comment.
Should we add && batch.network validation here, or there is no need?
Pabl0cks
reviewed
Aug 25, 2025
Comment on lines
+427
to
+428
| graduates: batch.graduates, | ||
| network: batch.network, |
Member
There was a problem hiding this comment.
Is this redundant in this case?
Contributor
Author
|
Oh shoots, this I just didn't see, sorry. And thank for the review! Since we discontinue batches, lets close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
With this PR I’m re-adding the link to the NFT contracts on OpenSea. Now that we’ve added the network field to the batch database, this is possible
Let me know what you think and hope its okay :)