Fetch builders and user roles data from SRE#148
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Refactored the builders data fetching into a new |
carletex
requested changes
Aug 18, 2025
Member
Author
|
Thx for the review @carletex !! Sorry it was a bit messy 😟 Resolved the conflicts and tried to address all the feedback. Please let me know if anything still doesn’t look right 🙌 |
carletex
reviewed
Aug 20, 2025
carletex
approved these changes
Aug 20, 2025
Member
carletex
left a comment
There was a problem hiding this comment.
Looking great, Pablo, thank you!!
Pushed a few little tweaks.
Let's keep an eye on and see if everything works as expected on the live site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were fetching builders data from firebase, and that info was not fresh anymore, since builders data got migrated into SRE.
Changes made:
multisig.pabl0cks.ethandadmin.buidlguidl.eth).rolefield in SRE.Closes #146