Skip to content

Fetch builders and user roles data from SRE#148

Merged
carletex merged 17 commits intomainfrom
builderdata-origin-sre
Aug 20, 2025
Merged

Fetch builders and user roles data from SRE#148
carletex merged 17 commits intomainfrom
builderdata-origin-sre

Conversation

@Pabl0cks
Copy link
Member

@Pabl0cks Pabl0cks commented Aug 4, 2025

We were fetching builders data from firebase, and that info was not fresh anymore, since builders data got migrated into SRE.

Changes made:

  • Updated the builder data fetch to read from the SRE API.
  • Also updated the admin role fetch to read from SRE. Added a couple of missing admins to the SRE database (multisig.pabl0cks.eth and admin.buidlguidl.eth).
  • Renamed the "builder" role to "user" to match the role field in SRE.
  • Removed some unused or unnecessary fields from the builder data that were not migrated to the SRE database:
    • Builder stream (legacy)
    • Legacy BG builder check in applications (those builders will now need to complete more challenges to apply, not a big deal)
    • Cohort data (we can add this later if we migrate it to SRE; for now, cohort builders are few enough to track manually during application review)

Closes #146

@Pabl0cks Pabl0cks requested a review from carletex August 4, 2025 15:53
@vercel
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
grants-bg Ready Ready Preview Comment Aug 20, 2025 8:24am

@Pabl0cks
Copy link
Member Author

Pabl0cks commented Aug 7, 2025

Refactored the builders data fetching into a new api/sre service folder, since it no longer had anything to do with the Firebase database 🙏

Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pablo, thanks for this.

I did a quick code review. Let me know if something is not clear or you need help.

(There are also some conflicts from main)

Thanks!!

@Pabl0cks
Copy link
Member Author

Thx for the review @carletex !! Sorry it was a bit messy 😟

Resolved the conflicts and tried to address all the feedback. Please let me know if anything still doesn’t look right 🙌

@Pabl0cks Pabl0cks requested a review from carletex August 19, 2025 17:42
Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, Pablo, thank you!!

Pushed a few little tweaks.

Let's keep an eye on and see if everything works as expected on the live site.

@carletex carletex merged commit da45142 into main Aug 20, 2025
3 checks passed
@carletex carletex deleted the builderdata-origin-sre branch August 20, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch builders data from SRE api

2 participants