feat: adding crawlee's EnqueueStrategy config#176
Open
muzafferkadir wants to merge 3 commits intoBuilderIO:mainfrom
Open
feat: adding crawlee's EnqueueStrategy config#176muzafferkadir wants to merge 3 commits intoBuilderIO:mainfrom
muzafferkadir wants to merge 3 commits intoBuilderIO:mainfrom
Conversation
Contributor
|
thanks @muzafferkadir ! looks like build is failing, so will need that in to merge. otherwise, great update |
Author
thanks, i updated |
Contributor
|
sorry @muzafferkadir - looks like theres a merge conflict. i can hop on this once green again |
Author
i updated |
Contributor
|
looks like build not passing @muzafferkadir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary:
This pull request introduces changes to the configuration schema and the crawling logic to enhance the flexibility of the crawling strategy. For more information: https://crawlee.dev/api/core/enum/EnqueueStrategy#All
Changes Made:
Updated Configuration Schema (
config.ts):crawlStrategyfield to the configuration schema."all","same-origin","same-hostname", and"same-domain".Updated Crawling Logic (
core.ts):crawlStrategyconfiguration into thePlaywrightCrawlersetup.strategyparameter inenqueueLinksnow uses theconfig.crawlStrategyvalue if provided.Impact:
Examples:
crawlStrategyis set to"same-origin", the crawler will only follow links within the same origin.crawlStrategyis set to"all", the crawler will follow all links regardless of their origin.