Skip to content

Add globset::Candidate::from_bytes constructor #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aawsome wants to merge 1 commit into from
Closed

Add globset::Candidate::from_bytes constructor #2955

aawsome wants to merge 1 commit into from

Conversation

@aawsome
Copy link
Contributor

@aawsome aawsome commented Dec 24, 2024

see #2954

BurntSushi
BurntSushi approved these changes Aug 17, 2025
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi added the rollup A PR that has been merged with many others in a rollup. label Aug 17, 2025
BurntSushi pushed a commit that referenced this pull request Aug 17, 2025
@aawsome @BurntSushi
globset: add Candidate::from_bytes constructor
6fb5296 
This is already technically possible to do on Unix by going through
`OsStr` and `&[u8]` conversions. This just makes it easier to do in all
circumstances and is reasonable to intentionally support.

Closes #2954, Closes #2955
BurntSushi pushed a commit that referenced this pull request Sep 10, 2025
@aawsome @BurntSushi
globset: add Candidate::from_bytes constructor
b38a5c6 
This is already technically possible to do on Unix by going through
`OsStr` and `&[u8]` conversions. This just makes it easier to do in all
circumstances and is reasonable to intentionally support.

Closes #2954, Closes #2955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees

No one assigned

Labels

rollup A PR that has been merged with many others in a rollup.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aawsome @BurntSushi