add get media download url functionality #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add getMediaDownloadUrl method * fix linting * lint
adambuczek
changed the title
betacar
added a commit
that referenced
this pull request
Jan 4, 2021
* ESLint config clean up * Gulp replaced with Rollup * Beblified modules * Discard browser builds for now * Identation fix * UUID package added * Do not ignore package-lock files * For no-console and single-quote * Generate a package-lock file and track it * Generate docs through NPM scripts * Old dependencies removed * Don't let rollup include external dependencies * Ignore ENV file * Unnecessary Jasmine files removed * Don't include the docs nor the coverage on the NPM bundle * Babel config extracted from package file * Main API file extracted from SDK file * Constants and utils file created * New bynder module * Use optional chaining to check if file body exists * WIP * Docs command fix * ESlint config fixed * Unrequired proper-url-join package removed * Use an axios instance instead of creating a new one everytime * New mocked functions helpers * WIP * Build support for Node 12, 13, and 14 added * Test fixed * API class tests * Package files added * Use the standarized UA name * Tests fixed * Catch request errors correctly + API class documentation improvements * New FS workflow w/ prepare endpoint support * Version bump * New metapropertyOptions endpoint support Closes #51 * Media download URL endpoint support added Closes #49 * Save asset method fixed * README updated with new methods * File chunks method added to README file * Ignore lines for CC * USe Jest's spy objects for a cleaner implementation * Chunk uploader bug fixed * Sample script replaced * Front-end related code removed * Pretest script fixed * Use existing scripts for consistency * Typo fix * Endpoint specific headers can sent through the API client * Utils tests cases * Include the content sha and media ID * More tests cases * SHA256 Hex generator moved to the utils file * Send intent and SHA256 on finalise upload endpoint request * Moar tests added * Docs updated * Return arrays as data attr * URL namespaces fixed * Only encode files when hitting a non V6 and V7 endpoint * Moar tests * Documentation improvements * Send headers separately from body payload * Correct finalise endpoint + header improvements * Last set of tests added * Review changes * Unused deps removed * Run GitHub actions within supported NodeJS versions * Readable stream file body are supported * isomorphic-form-data removed * Support for stream uploads added * Debug lines removed * Fiel intent removed * Form data moved * Don't use Yarn * Smol documentation fixes * Return an array, and no headers, when an array is responded * Detect V4 and V5 only routes
betacar
added a commit
that referenced
this pull request
May 10, 2021
* ESLint config clean up * Gulp replaced with Rollup * Beblified modules * Discard browser builds for now * Identation fix * UUID package added * Do not ignore package-lock files * For no-console and single-quote * Generate a package-lock file and track it * Generate docs through NPM scripts * Old dependencies removed * Don't let rollup include external dependencies * Ignore ENV file * Unnecessary Jasmine files removed * Don't include the docs nor the coverage on the NPM bundle * Babel config extracted from package file * Main API file extracted from SDK file * Constants and utils file created * New bynder module * Use optional chaining to check if file body exists * WIP * Docs command fix * ESlint config fixed * Unrequired proper-url-join package removed * Use an axios instance instead of creating a new one everytime * New mocked functions helpers * WIP * Build support for Node 12, 13, and 14 added * Test fixed * API class tests * Package files added * Use the standarized UA name * Tests fixed * Catch request errors correctly + API class documentation improvements * New FS workflow w/ prepare endpoint support * Version bump * New metapropertyOptions endpoint support Closes #51 * Media download URL endpoint support added Closes #49 * Save asset method fixed * README updated with new methods * File chunks method added to README file * Ignore lines for CC * USe Jest's spy objects for a cleaner implementation * Chunk uploader bug fixed * Sample script replaced * Front-end related code removed * Pretest script fixed * Use existing scripts for consistency * Typo fix * Endpoint specific headers can sent through the API client * Utils tests cases * Include the content sha and media ID * More tests cases * SHA256 Hex generator moved to the utils file * Send intent and SHA256 on finalise upload endpoint request * Moar tests added * Docs updated * Return arrays as data attr * URL namespaces fixed * Only encode files when hitting a non V6 and V7 endpoint * Moar tests * Documentation improvements * Send headers separately from body payload * Correct finalise endpoint + header improvements * Last set of tests added * Review changes * Unused deps removed * Run GitHub actions within supported NodeJS versions * Readable stream file body are supported * isomorphic-form-data removed * Support for stream uploads added * Debug lines removed * Fiel intent removed * Form data moved * Don't use Yarn * Smol documentation fixes * Return an array, and no headers, when an array is responded * Detect V4 and V5 only routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
getMediaDownloadUrlmethod