Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce yup-oauth2 features #539

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Feb 2, 2025

Closes #533

@paolobarbolini paolobarbolini force-pushed the reduce-yup-oauth2-features branch 7 times, most recently from 470324a to ce126d6 Compare February 2, 2025 16:30
@paolobarbolini paolobarbolini marked this pull request as ready for review February 2, 2025 16:46
@Byron Byron marked this pull request as draft February 5, 2025 06:59
@Byron
Copy link
Owner

Byron commented Feb 5, 2025

I think this PR needs a little more context so I can understand its progress, hence I have put it into draft mode. Please let me know when you think it's ready.

@paolobarbolini paolobarbolini force-pushed the reduce-yup-oauth2-features branch from ce126d6 to 394c8ed Compare February 16, 2025 20:11
@paolobarbolini paolobarbolini marked this pull request as ready for review February 16, 2025 20:17
@paolobarbolini
Copy link
Contributor Author

This is now ready to be merged.

@paolobarbolini paolobarbolini force-pushed the reduce-yup-oauth2-features branch 2 times, most recently from fcefec9 to 6ad5edd Compare February 16, 2025 20:34
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I think I pieced together what the PR is supposed to do, but would hope you could add comments (in document-features style) so it becomes clearer how these new features are supposed to be used, and to verify I actually do get what's intended.

Also, would you think the major version of the crates needs to be bumped? Isn't this a breaking change without adding the previous default-features back in (if that's even possible)?

@@ -32,7 +32,7 @@ clap = "2"
http-body-util = "0.1"
% endif
hyper = "1"
hyper-rustls = { version = "0.27", default-features = false }
hyper-rustls = { version = "0.27", default-features = false, features = ["http2", "rustls-native-certs", "native-tokio"] }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these are enabled by default now?

Copy link
Contributor Author

@paolobarbolini paolobarbolini Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were already enabled by yup-oauth2 before, but since we now compile it without the hyper-rustls feature we have to enable them ourselves.

@paolobarbolini paolobarbolini force-pushed the reduce-yup-oauth2-features branch from 6ad5edd to 4f9a114 Compare February 17, 2025 08:43
@paolobarbolini
Copy link
Contributor Author

paolobarbolini commented Feb 17, 2025

I think I pieced together what the PR is supposed to do, but would hope you could add comments (in document-features style) so it becomes clearer how these new features are supposed to be used, and to verify I actually do get what's intended.

Done

Also, would you think the major version of the crates needs to be bumped?

They would have to anyways because upgrading yup-oauth2 in #536 is already a breaking change.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Thanks for clarifying the breaking change as well.

Then I think we can merge once the cargo.build_version was updated in shared.yml.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@paolobarbolini
Copy link
Contributor Author

Is there anything left to be done for this to be merged?

@Byron
Copy link
Owner

Byron commented Feb 26, 2025

Apologies, I somehow failed to hit the merge button.

@Byron Byron merged commit 15bbb88 into Byron:main Feb 26, 2025
5 of 6 checks passed
@paolobarbolini
Copy link
Contributor Author

Should I send a PR to do the release?

@Byron
Copy link
Owner

Byron commented Feb 27, 2025

At this point I think I'd have to do that myself. Something that should be done before is to update all APIs and maybe provide new crates in the process (for new APIs).
I'd like to wait more to let it settle though - users of these crates are probably quite used to using vendored versions anyway given how infrequently they update.
Maybe as an intermediate step, documentation could be added to show how to rebuild an API crate and use it via vendoring?

@paolobarbolini
Copy link
Contributor Author

Given how easy it is to make new releases in the Rust world and how easy it is for users who don't want to upgrade immediately to stand back, I'd rather not vendor. I think Rust makes it easy to have an upstream-first approach but that stops working when new releases then take too long to come out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable ring feature from yup-oauth2
2 participants