-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce yup-oauth2 features #539
Conversation
470324a
to
ce126d6
Compare
I think this PR needs a little more context so I can understand its progress, hence I have put it into draft mode. Please let me know when you think it's ready. |
ce126d6
to
394c8ed
Compare
This is now ready to be merged. |
fcefec9
to
6ad5edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I think I pieced together what the PR is supposed to do, but would hope you could add comments (in document-features
style) so it becomes clearer how these new features are supposed to be used, and to verify I actually do get what's intended.
Also, would you think the major version of the crates needs to be bumped? Isn't this a breaking change without adding the previous default-features back in (if that's even possible)?
@@ -32,7 +32,7 @@ clap = "2" | |||
http-body-util = "0.1" | |||
% endif | |||
hyper = "1" | |||
hyper-rustls = { version = "0.27", default-features = false } | |||
hyper-rustls = { version = "0.27", default-features = false, features = ["http2", "rustls-native-certs", "native-tokio"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come these are enabled by default now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were already enabled by yup-oauth2
before, but since we now compile it without the hyper-rustls
feature we have to enable them ourselves.
6ad5edd
to
4f9a114
Compare
Done
They would have to anyways because upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Thanks for clarifying the breaking change as well.
Then I think we can merge once the cargo.build_version
was updated in shared.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Is there anything left to be done for this to be merged? |
Apologies, I somehow failed to hit the merge button. |
Should I send a PR to do the release? |
At this point I think I'd have to do that myself. Something that should be done before is to update all APIs and maybe provide new crates in the process (for new APIs). |
Given how easy it is to make new releases in the Rust world and how easy it is for users who don't want to upgrade immediately to stand back, I'd rather not vendor. I think Rust makes it easy to have an upstream-first approach but that stops working when new releases then take too long to come out. |
Closes #533