mac: move tests to a separate file #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenesvk
force-pushed
the
fr-mac-test-out
branch
from
d30b27d to
7ab96de
Compare
Byron
requested changes
Dec 7, 2024
Owner
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot!
I think now with the dependent PR merged and squashed, this one needs to be redone. And while doing that, could you make macos a directory and create tests.rs in there?
Contributor
Author
|
ok, btw, your auto-release notes are a bit wrong, you removed simd, so "add simdutf8 for fast utf8 validation" wasn't added |
eugenesvk
force-pushed
the
fr-mac-test-out
branch
from
7ab96de to
fec6e75
Compare
Contributor
Author
|
rebased, though kept the names so that you don't have dupe "tests" or "mods" in the editor |
Byron
force-pushed
the
fr-mac-test-out
branch
from
073f7f2 to
7c7a34c
Compare
Co-authored-by: Sebastian Thiel <[email protected]>
Byron
force-pushed
the
fr-mac-test-out
branch
from
7c7a34c to
ee7f256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tests are getting longer, they make it a bit harder finding main code functions among test dupes and overall navigation, so moved them out
based on #131