Skip to content

__TEST of AS in CI #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eugenesvk wants to merge 55 commits into from
Closed

__TEST of AS in CI #133

eugenesvk wants to merge 55 commits into from

Conversation

@eugenesvk
Copy link
Contributor

@eugenesvk eugenesvk commented Dec 7, 2024 •
edited
Loading

resolved

@eugenesvk
update fn visibility
4524b29
@eugenesvk
mac: move to a macos folder
fec6e75 
move tests out to a separate file
@eugenesvk
fmt
073f7f2
@eugenesvk
Return trash items that are created by delete (old FR)
b4788f3
@eugenesvk
fix mac return signatures
4ad0ca4
@eugenesvk
update doc
5ca12f8
@eugenesvk
dep: add chrono to macOS
a72732e
@eugenesvk
add support for getting trashed items' data
05395de 
actual deleted time as recorded in file metadata (`kMDItemDateAdded`) seems inaccessible to us when a file is in the trash, so this follows the Linux approach of getting system time instead
@eugenesvk
return a single TrashItem for a single trashed item
46de4a8 
instead of currently returning a vec just because 1 delete still goes through delete_all
@eugenesvk
update docs
68643fd
@eugenesvk
__TODO why is this needed?
87b3eac
@eugenesvk
mac: split delete functions into 2 categories: those that return tras…
d582de9 
…hed items and those that done

so that you can avoid the overhead of storing all the info you might not need
@eugenesvk
fmt
7e1a6b0
@eugenesvk
fix wrong delete arg order
440f48e
@eugenesvk
add stub arguments for Windows/Linux
1829481
@eugenesvk
fmt
2edf49c
@eugenesvk
upd comment
bac1586
@eugenesvk
test: add test_delete_binary_path_with_ns_file_manager_with_info
7b1a8b1
@eugenesvk
dep: add osakit to parse AppleScript's output
5143694
@eugenesvk
update description
bce5742
@eugenesvk
mac: add support for Finder returned url to trashed items
48939f9 
replace cmd osascript with Objc bindings with osakit to allow proper results parsing
@eugenesvk
test: add test_delete_with_finder_with_info
0c75bc4
@eugenesvk
test: add test_delete_with_finder_with_info_invalid
e0f5964
@eugenesvk
test: add test_delete_binary_with_finder_with_info
edfe228
@eugenesvk
fix 1 item not being returned from AppleScript
e2e3529 
was treated as a list but it was a single item
@eugenesvk
test: add 1-file delete test to test_delete_with_finder_with_info
c0436a6
@eugenesvk
fmt
4544157
@eugenesvk
fix variable type detection in AppleScript
fc84e48
@eugenesvk
set an empty return to AS with no info so it can be parsed by osakit
3c8fa4f
@eugenesvk
test: add test_delete_with_finder
d2189d1
@eugenesvk eugenesvk mentioned this pull request Dec 7, 2024
Open
@Byron
Copy link
Owner

Byron commented Dec 7, 2024

May I recommend you to rewrite existing commits? It's either git commit --amend, or Stacked Git which is what I use for that.

@eugenesvk
Copy link
Contributor Author

eugenesvk commented Dec 7, 2024

oh, this is not meant for merging, just CI runs

@eugenesvk eugenesvk mentioned this pull request Dec 7, 2024
Closed
@eugenesvk eugenesvk closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eugenesvk @Byron