Skip to content

Fix set_rocshmem_ctx & Add signal_wait_until #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erieaton-amd wants to merge 1 commit into
base: dist
Choose a base branch
from
Open

Fix set_rocshmem_ctx & Add signal_wait_until #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 43 additions & 23 deletions third_party/amd/language/hip/librocshmem_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def set_rocshmem_ctx(ctx, _semantic=None):
tl.cast(ctx, tl.pointer_type(tl.void), _semantic=_semantic),
],
{
(tl.pointer_type(tl.void),): ("rocshmem_set_ctx", ()),
(tl.pointer_type(tl.void),): ("rocshmem_set_rocshmem_ctx", ()),
},
is_pure=False,
_semantic=_semantic,
Expand Down Expand Up @@ -480,30 +480,50 @@ def putmem_signal_nbi_wave(dest,
)


@core.extern
def signal_wait_until(sig_addr, cmp_, cmp_val, _semantic=None):
tl.static_assert(sig_addr.dtype == pi_u64_t or sig_addr.dtype == pi_i64_t,
"sig_addr should be a pointer of uint64_t/int64_t",
_semantic=_semantic)
return extern_call(
"librocshmem_device",
"",
[
tl.cast(sig_addr, pi_u64_t, _semantic=_semantic),
tl.cast(cmp_, tl.int32, _semantic=_semantic),
tl.cast(cmp_val, tl.uint64, _semantic=_semantic),
], # no cast
{
(pi_u64_t, tl.int32, tl.uint64): (
"rocshmem_ulong_wait_until_wrapper",
(),
),
},
is_pure=False,
_semantic=_semantic,
)


# @core.extern
# def wait_until(sig_addr, cmp_, cmp_val, _semantic=None):
# tl.static_assert(sig_addr.dtype == pi_u64_t or sig_addr.dtype == pi_i64_t,
# "sig_addr should be a pointer of uint64_t/int64_t",
# _semantic=_semantic)
# return extern_call(
# "librocshmem_device",
# "",
# [
# tl.cast(sig_addr, pi_u64_t, _semantic=_semantic),
# tl.cast(cmp_, tl.int32, _semantic=_semantic),
# tl.cast(cmp_val, tl.uint64, _semantic=_semantic),
# ], # no cast
# {
# (pi_u64_t, tl.int32, tl.uint64): (
# "rocshmem_wait_until_wrapper",
# (),
# ),
# },
# is_pure=False,
# _semantic=_semantic,
# )
@core.extern
def ulong_put_signal(dest, source, nelems, sig_addr, signal, sig_op, pe, _semantic=None):
return extern_call(
"librocshmem_device",
"",
[
tl.cast(dest, pi_u64_t, _semantic=_semantic),
tl.cast(source, pi_u64_t, _semantic=_semantic),
tl.cast(nelems, tl.uint64, _semantic=_semantic),
tl.cast(sig_addr, pi_u64_t, _semantic=_semantic),
tl.cast(signal, tl.uint64, _semantic=_semantic),
tl.cast(sig_op, tl.int32, _semantic=_semantic),
tl.cast(pe, tl.int32, _semantic=_semantic),
],
{
(pi_u64_t, pi_u64_t, tl.uint64, pi_u64_t, tl.uint64, tl.int32, tl.int32): (
"rocshmem_ulong_put_signal_wrapper",
(),
),
}, is_pure=False, _semantic=_semantic)


@core.extern
Expand Down