Fixed missing attribution for acme-client and Sympl (stretch)#144
Open
Kelduum wants to merge 4 commits into
Open
Fixed missing attribution for acme-client and Sympl (stretch)#144Kelduum wants to merge 4 commits into
Kelduum wants to merge 4 commits into
Conversation
Updating to current
Fixed missing copyright
Added missing attribution.
Author
|
Note: #145 includes support for Symbiosis Jessie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribution and copyright notices were missed with the symbiosis-common changes made back in February to add support for Let's Encrypt ACMEv02 challenges.
This included folding in the 'acme-client' from https://github.com/unixcharles/acme-client into the symbiosis-common package, and back-porting the changes made in Sympl (a fork of Symbiosis supported by Mythic Beasts).
This was apparently a straight copy and paste with some small variable name reversions in order to support the new library.
This change should make Symbiosis properly compliant again.