Add Cognito Tokens using SecretsManager #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
InnocentBug
reviewed
Apr 9, 2024
InnocentBug
left a comment
InnocentBug
left a comment
There was a problem hiding this comment.
LGTM
I won't approve for merge, since there are some other parts, I want this in too.
And I want to merge this after save and search work, so tests continue to be green.
| @@ -1,7 +1,7 @@ | |||
| # CRIPT DEVELOPMENT TEAM | |||
|
|
|||
| - [Navid Hariri](https://github.com/nh916) | |||
There was a problem hiding this comment.
Navid did contribute, any reason we should remove him?
| # Cancel in-progress runs when a new workflow with the same group name is triggered | ||
| cancel-in-progress: true | ||
|
|
||
| env: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed CI