Skip to content

test: make dbt and warehouse tests hermetic#144

Merged
C00ldudeNoonan merged 2 commits into
mainfrom
codex/issue-134-hermetic-tests
Jul 11, 2026
Merged

test: make dbt and warehouse tests hermetic#144
C00ldudeNoonan merged 2 commits into
mainfrom
codex/issue-134-hermetic-tests

Conversation

@C00ldudeNoonan

Copy link
Copy Markdown
Owner

Summary

  • make dbt dependency installation explicit and parse the project once per test session
  • block network access in the default pytest suite while keeping SEC functional tests opt-in
  • close Dagster and DuckDB test resources deterministically
  • add SQLFluff and critical-path coverage enforcement to CI

Validation

  • 454 tests passed with 27 network tests deselected
  • critical-path coverage: 51.69% against a 50% floor
  • Ruff, ty, SQLFluff, actionlint, and Dagster definition validation passed
  • opt-in SEC functional suite: 27 passed

Closes #134

@C00ldudeNoonan

Copy link
Copy Markdown
Owner Author

@codex please review this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a347e6f2f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread macro_agents/src/macro_agents/defs/transformation/dbt.py
@C00ldudeNoonan
C00ldudeNoonan merged commit 57b6fc2 into main Jul 11, 2026
2 checks passed
@C00ldudeNoonan
C00ldudeNoonan deleted the codex/issue-134-hermetic-tests branch July 11, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: make dbt and warehouse tests hermetic and cover production query behavior

1 participant