minor bug fixes to grid_opt.py#10
Open
cseaton wants to merge 1 commit intoCADWRDeltaModeling:masterfrom
Open
Conversation
args.optparm is created , but then used as args.optparam, so I changed it to args.optparm args.na_fill is never defined. I added a line to provide a default value for na_fill. Probably needs to be a command line argument with a default value, but this at least allows the code to run.
Collaborator
|
We agree in general, but we're working out the default for na_fill. There are some reasons why na_fill = None (fail if not covered) is preferable because silently filling -9999 will pass pain. The real issue is in stacked_dem_fill.py. We are thinking of eliminating require_all and making this implied by na_fill = None. In the meantime there is nothing bad about this as long as it works for you or there are no holes in your elevation coverage. |
lily-tomkovic-DWR
force-pushed
the
master
branch
from
8874f32 to
25b55c0
Compare
lily-tomkovic-DWR
force-pushed
the
master
branch
23 times, most recently
from
925cefe to
66695b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
args.optparm is created , but then used as args.optparam, so I changed it to args.optparm
args.na_fill is never defined. I added a line to provide a default value for na_fill. Probably needs to be a command line argument with a default value, but this at least allows the code to run.