-
Notifications
You must be signed in to change notification settings - Fork 12
AuraStealer update #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add more data sections that may contain the configuration
Summary of ChangesHello @enzok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the extract_config function in AuraStealer.py to improve how data sections are identified within PE files. The changes replace a try-except block with a more explicit loop that iterates through PE sections, decodes their names, and checks for exact matches against UPX1 or .data. This enhances robustness and clarity in locating relevant configuration data sections.
| name = s.Name.decode("utf-8", errors="ignore").rstrip("\x00") | ||
| if name in ("UPX1", ".data"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original code used s.Name.find(b".data") != -1 which would match any section name containing .data as a substring. The updated code uses name in ("UPX1", ".data") which requires an exact match for the decoded and null-stripped section name. This is a more precise approach for standard section names and UPX1. Please confirm that the intent is to only match these exact names and not any section containing .data as a substring, as this change in matching logic could alter behavior for non-standard PE files.
Add more data sections that may contain the configuration