-
Notifications
You must be signed in to change notification settings - Fork 12
Update LokiBot.py #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
typo on line 154
File "/updates/tmpo4x8jqa8/CAPE_PARSERS/cape_parsers/CAPE/community/LokiBot.py", line 154, in decoder urls.append("http://" + temp.decod()) ^^^^^^^^^^ AttributeError: 'bytes' object has no attribute 'decod'. Did you mean: 'decode'?
Summary of ChangesHello @cccs-js, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a typo on line 154 of LokiBot.py, changing temp.decod() to temp.decode() to prevent an AttributeError. While this fixes the immediate bug, I've added a suggestion to improve the robustness of the string decoding. By explicitly using the 'latin-1' encoding, we can prevent potential UnicodeDecodeError exceptions and ensure that all data from the decrypted configuration is preserved, which is a good practice in malware analysis.
| if not temp.endswith(b".php"): | ||
| continue | ||
| urls.append("http://" + temp.decod()) | ||
| urls.append("http://" + temp.decode()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While decode() fixes the AttributeError, relying on the default encoding (usually UTF-8) can be fragile when dealing with malware artifacts. A UnicodeDecodeError would be raised for invalid byte sequences, which is currently suppressed by the with suppress(ValueError) block on line 148.
To make the decoding more robust and explicit, I suggest using an encoding like 'latin-1', which can represent any byte value. This avoids exceptions and ensures that the entire string is preserved, which is often desirable in malware analysis.
| urls.append("http://" + temp.decode()) | |
| urls.append("http://" + temp.decode("latin-1")) |
|
oh yes that is my keyboard that sometimes ignores |
typo on line 154
File "/CAPE_PARSERS/cape_parsers/CAPE/community/LokiBot.py", line 154, in decoder urls.append("http://" + temp.decod()) ^^^^^^^^^^ AttributeError: 'bytes' object has no attribute 'decod'. Did you mean: 'decode'?