Chore: remove unused extract_patch method in ImageStack implementations#724
Merged
Conversation
melisande-c
approved these changes
Feb 3, 2026
Member
melisande-c
left a comment
melisande-c
left a comment
There was a problem hiding this comment.
Should extract_channel_patch be renamed to extract_patch? There is no need to distinguish a patch from a channel patch and it is a little less verbose
Member
Author
That's a good idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #640
ImageStack.extract_patchis not used anymore and the dataset instead callsImageStack.extract_channel_patch. This PR removes the methods and their calls in tests.Closes #708