Skip to content

Fix precomputed info #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix precomputed info #203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ee298
fixing precomputed properties when not valid column exists
fcollman Oct 24, 2025
6dfc327
remove unneeded line
fcollman Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion materializationengine/blueprints/client/api2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1992,8 +1992,8 @@
continue
elif c.endswith("pt_root_id"):
continue
if c in geometry_columns:
continue

Check failure on line 1996 in materializationengine/blueprints/client/api2.py

View workflow job for this annotation

GitHub Actions / Test against different Python versions (3.10)

Ruff 

materializationengine/blueprints/client/api2.py:1996:9: SyntaxError: Expected an indented block after `elif` clause

Check failure on line 1996 in materializationengine/blueprints/client/api2.py

View workflow job for this annotation

GitHub Actions / Test against different Python versions (3.10)

Ruff 

materializationengine/blueprints/client/api2.py:1995:41: SyntaxError: Expected ':', found newline
elif c in unique_values.keys():
prop = viewer_state.AnnotationPropertySpec(
id=c,
Expand Down Expand Up @@ -2565,6 +2565,8 @@
geometry_columns[1] + "_y",
geometry_columns[1] + "_z",
]
else:
abort("400", "Unsupported annotation type {}".format(anntype))
for p in properties:
if p.enum_values is not None:
df[p.id].replace(
Expand All @@ -2578,7 +2580,7 @@
for r in relationships:
if r in df.columns:
kwargs[r] = df.loc[i, r]
if row["valid"]:
if row.get("valid", True):
if anntype == "point":
point = df.loc[i, point_cols].tolist()
writer.add_point(point, id=df.loc[i, "id"], **kwargs)
Expand Down
Loading