Open
Conversation
a783cca to
6252712
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was currently no way to remove workspaces so I added a method.
Method could also return void, but I prefer to be able to differentiate between actually removing something or doing nothing because the workspace is not there.
Additionally I noticed, that when a Workspace is shutdown through the .shutdown() method it will (catch) but log many exceptions like this:
This is because the shutdown() method calls the stopActivity() method in the EnvironmentController of the workspace. Which interrupts the thread. and the run() method of the Environment Controller is set to log all exceptions. I just added a case for when it is an instance of InterruptedException and isStopped() return true it will not log anything, because it works as expected.