Skip to content

Common - Improve fnc_isTerrainObject#1816

Merged
PabstMirror merged 2 commits intoCBATeam:masterfrom
DartRuffian:improve-isTerrainObject
Mar 24, 2026
Merged

Common - Improve fnc_isTerrainObject#1816
PabstMirror merged 2 commits intoCBATeam:masterfrom
DartRuffian:improve-isTerrainObject

Conversation

@DartRuffian
Copy link
Copy Markdown
Contributor

@DartRuffian DartRuffian commented Mar 19, 2026

When merged this pull request will:

  • Improve fnc_isTerrainObject by checking its net id instead of using nearestTerrainObjects.
    • Saved ~4ms @ 10k iterations:
player call CBA_fnc_isTerrainObject; // Execution Time: 0.0041 ms  |  Cycles: 10000/10000  |  Total Time: 41 ms
player call ace_common_fnc_isTerrainObject; // Execution Time: 0.0037 ms  |  Cycles: 10000/10000  |  Total Time: 37 ms

@DartRuffian DartRuffian mentioned this pull request Mar 19, 2026
Merged
PabstMirror
PabstMirror reviewed Mar 22, 2026
View reviewed changes
@DartRuffian @PabstMirror
Update addons/common/fnc_isTerrainObject.sqf
51b0302 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror added this to the 3.18.6 milestone Mar 24, 2026
@PabstMirror PabstMirror merged commit 510e207 into CBATeam:master Mar 24, 2026
3 checks passed
PabstMirror added a commit that referenced this pull request Mar 27, 2026
@PabstMirror
Revert "Merge pull request #1816 from DartRuffian/improve-isTerrainOb…
4482317 
…ject"

This reverts commit 510e207, reversing
changes made to 899d18b.
@PabstMirror PabstMirror mentioned this pull request Mar 27, 2026
Merged
PabstMirror added a commit that referenced this pull request Mar 27, 2026
@PabstMirror
Merge pull request #1817 from CBATeam/revertTO
21781d6 
Revert "Merge pull request #1816 from DartRuffian/improve-isTerrainOb…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

Assignees

No one assigned

Labels

Enhancement Ignore Changelog

Projects

None yet

Milestone

3.18.6

Development

Successfully merging this pull request may close these issues.

2 participants

@DartRuffian @PabstMirror