INS-1506 Updated Dataset Search Results #486
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds study type as a conditionally rendered field in dataset search results, relocates institute and experimental approaches to hidden fields, and adds comprehensive test coverage.
- Elevated study type to a conditional field displayed between primary disease and sample count
- Added institute and experimental approaches to hidden searchable fields ("Other Match in...")
- Implemented extensive test suite achieving 100% coverage including edge cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SearchResult.test.jsx | Added comprehensive test suite covering conditional field rendering, hidden field matching, search filtering, highlighting behavior, and edge cases |
| SearchResult.js | Added study type as conditional field with highlighting support, moved institute and experimental approaches to hidden fields array, removed unused sorting code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amattu2
left a comment
amattu2
left a comment
There was a problem hiding this comment.
One minor suggestion for the unit tests. Code functionally looks good.
… updated test suite name to remove string literal
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Overview
Updated dataset search results to have a conditional fields for study type + new hidden fields for institute and experimental approaches + testing.
Change Details (Specifics)
Related Ticket(s)
INS-1506