C3DC-2003 - 1.8.0 Design QA Explore Tabs + Table #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Design QA updates for the explore tabs and table interface, focusing on text styling, spacing adjustments, and dropdown menu refinements. The changes address specific Figma design specifications to improve visual consistency and alignment with design standards.
Key changes:
- Updated text transform from capitalize to uppercase for tab labels with adjusted font size and line spacing
- Removed spacing between tabs and buttons
- Adjusted dropdown menu item padding and spacing for improved visual hierarchy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@huuaho Can you resolve the merge conflicts on this? |
amattu2
requested changes
Dec 30, 2025
amattu2
previously approved these changes
Dec 30, 2025
Contributor
amattu2
left a comment
amattu2
left a comment
There was a problem hiding this comment.
LGTM. Once you resolve the merge conflicts, you can merge this.
amattu2
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C3DC-2003
Please Approve the PR on the library side before this PR
CBIIT/bento-frontend#1181
Design QA updates
220 - #220 Text should be uppercase, not capitalized; Also make sure size is 17 pt and line spacing at 16
221 - #221 There should be 0px of space between tabs and buttons
263 - Tab color borders are all the same when activated: #006A8F
265 -
221 and 263 were already resolved
265 is fixed in the package update as well as an updated styling for the manage columns popup divider.