C3DC-2063 #464
Merged
C3DC-2063 #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates chart styling and typography in the Histogram component, adjusting font sizes, line heights, and spacing for both standard and expanded chart views. The changes also update the risk-table dependency to incorporate related improvements.
- Standardizes font sizes to 11px (standard view) and 13px (expanded view) with matching line heights
- Adds conditional spacing for specific datasets (race, treatmentType, response)
- Refactors inline styles to use CSS classes for better maintainability
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pages/CohortAnalyzer/HistogramPanel/HistogramPopup.js | Updates expanded chart view with larger font sizes (13px) and adjusted bottom margin |
| src/pages/CohortAnalyzer/HistogramPanel/Histogram.js | Implements conditional styling for specific datasets and standardizes typography with configurable font properties |
| src/pages/CohortAnalyzer/HistogramPanel/CustomXAxisTick.js | Adds lineHeight and letterSpacing props to support new typography customization |
| package.json | Bumps @bento-core/risk-table dependency from 1.0.0-c3dc.2 to 1.0.0-c3dc.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Collaborator
Author
1 similar comment
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.